Postgres bulk_create error when geometry is null or a different SRID

[Joshua Goodwin]

I have a model with a geometry field like this:

from django.contrib.gis.db import models

class Garage(models.Model):
    name = models.CharField(max_length=100, blank=True)
    location = models.PointField(null=True, blank=True)

With Django 5.2 and PostgreSQL (17.4 / PostGIS 3.5.2), bulk_create fails when I try to more than one item with a null location:

Garage.objects.bulk_create([Garage(), Garage()])

InternalError: parse error - invalid geometry
LINE 1: ...stimes_garage" ("location") SELECT * FROM UNNEST(('{NULL,NUL...
                                                             ^
HINT:  "NU" <-- parse error at position 2 within geometry

or with an SRID other than the default

Garage.objects.bulk_create([Garage(location="SRID=29902;POINT(624210 307091)"), Garage(location="SRID=29902;POINT(624210 307091)")])

DataError: Geometry SRID (29902) does not match column SRID (4326)

This seems to be a regression in 5.2, maybe related to #35936 (Speeding up Postgres bulk_create by using unnest)

[Sarah Boyce]

Thank you for the report!

Replicated, regression in a16eedcf9c69d8a11d94cac1811018c5b996d491
Basic regression test if useful:

tests/gis_tests/geo3d/models.py

@@ -58 +58 @@
 
 
 class Point2D(SimpleModel):
-    point = models.PointField()
+    point = models.PointField(null=True)
 
 
 class Point3D(SimpleModel):

tests/gis_tests/geo3d/tests.py

@@ -206 +206 @@
         lm.save()
         self.assertEqual(3, MultiPoint3D.objects.count())
 
+    def bulk_create_point_field(self):
+        objs = Point2D.objects.bulk_create([Point2D(), Point2D()])
+        self.assertEqual(len(objs), 2)
+
     @skipUnlessDBFeature("supports_3d_functions")

[Simon Charette]

The most simple solution is likely to adapt assemble_as_sql to disable the optimization if any field has a geometry db type.

[Simon Charette]

?PR

[Mariusz Felisiak <felisiak.mariusz@…>]

In 764af7a:

Fixed #36289 -- Fixed bulk_create() crash with nullable geometry fields on PostGIS.

Swapped to an allow list instead of a deny list for field types to
determine if the UNNEST optimization can be enabled to avoid further
surprises with other types that would require further specialization to
adapt.

Regression in a16eedcf9c69d8a11d94cac1811018c5b996d491.

Thanks Joshua Goodwin for the report and Sarah Boyce for the test.

[Mariusz Felisiak <felisiak.mariusz@…>]

In d9bf0d0:

[5.2.x] Fixed #36289 -- Fixed bulk_create() crash with nullable geometry fields on PostGIS.

Swapped to an allow list instead of a deny list for field types to
determine if the UNNEST optimization can be enabled to avoid further
surprises with other types that would require further specialization to
adapt.

Regression in a16eedcf9c69d8a11d94cac1811018c5b996d491.

Thanks Joshua Goodwin for the report and Sarah Boyce for the test.

Backport of 764af7a3d6c0b543dcf659a2c327f214da768fe4 from main